dgb: port LTC pool NodeImpl into impl/dgb (real node, replaces skeleton) - #134
Closed
frstrtr wants to merge 1 commit into
Closed
dgb: port LTC pool NodeImpl into impl/dgb (real node, replaces skeleton)#134frstrtr wants to merge 1 commit into
frstrtr wants to merge 1 commit into
Conversation
Replace the compiling node.cpp/node.hpp skeleton with the full pool-layer NodeImpl, ported near-mechanically from impl/ltc (namespace ltc -> dgb; LevelDB net names litecoin -> digibyte). node.cpp now compiles share_tracker.hpp and share_check.hpp into a real translation unit, exercising the chain-score path. - node.hpp: BaseNode<dgb::Config, dgb::ShareChain, dgb::Peer>, async share downloader, tracker mutex/compute pipeline, broadcast, download, admin API. Config aggregator (core::Config<PoolConfig, CoinConfig>) declared inline since the dgb tree splits config into config_pool.hpp + config_coin.hpp (no config.hpp aggregator header). - node.cpp: full run-loop body (think, clean_tracker, prune, PPLNS window, heartbeat, outbound connection maintenance, whitelist/ban admin). - protocol_actual.cpp / protocol_legacy.cpp: per-message handlers (Actual/Legacy). - config_pool.cpp / config_coin.cpp: Fileconfig load()/get_default() bodies; config_coin.hpp gains the YAML convert<> specializations for P2PData/RPCData. - CMakeLists.txt: add dgb OBJECT lib (mirrors ltc lib) linking core/pool/sharechain/dgb_coin/btclibs/c2pool_storage/secp256k1; the dgb NodeImpl TU builds clean (target dgb). Coin-isolation preserved: changes confined to src/impl/dgb/. Wiring the c2pool-dgb executable to this lib requires edits in src/c2pool/ (main_dgb.cpp + CMakeLists.txt) which are out of scope for this slice.
This was referenced Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #132 (→#131→#129). Replaces the compiling node.cpp/node.hpp skeleton with the full pool-layer NodeImpl, ported near-mechanically from impl/ltc (namespace ltc→dgb; LevelDB net litecoin→digibyte).
node.cpp now compiles share_tracker.hpp + share_check.hpp into a REAL translation unit, exercising the chain-score path — this makes #132 (block_period-derived time_span) real and lets the smoke drive the score path.
m_coin_params(dgb::make_coin_params(...)) mirrors ltc/node.hpp:131-151 (consumes #129 factory + #131 oracle params).
Coin-isolation preserved: confined to src/impl/dgb/. Wiring c2pool-dgb executable (src/c2pool/ main_dgb.cpp + CMakeLists) is a separate slice, out of scope here.
Verified: cmake --build --target dgb → clean (EXIT=0).
HOLD merge — integrator batches with #129/#131/#132.